Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in the logs #95

Merged
merged 13 commits into from
Jan 16, 2025
Merged

Updates in the logs #95

merged 13 commits into from
Jan 16, 2025

Conversation

thakurajayL
Copy link
Contributor

Logging updates and code review.

@thakurajayL thakurajayL force-pushed the thakurajayL-patch branch 5 times, most recently from a46343e to 2ea5f1a Compare January 13, 2025 03:09
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good. Adding some comments

drsm/api.go Show resolved Hide resolved
drsm/api.go Outdated Show resolved Hide resolved
drsm/api.go Outdated Show resolved Hide resolved
drsm/api.go Outdated Show resolved Hide resolved
drsm/api.go Outdated Show resolved Hide resolved
drsm/chunk.go Outdated Show resolved Hide resolved
drsm/claim.go Outdated Show resolved Hide resolved
@gab-arrobo
Copy link
Contributor

@thakurajayL, you need to sign-off your commit(s) to successfully pass the DCO check

@thakurajayL thakurajayL force-pushed the thakurajayL-patch branch 2 times, most recently from 37ad06e to fb9c009 Compare January 15, 2025 17:38
drsm/chunk.go Outdated Show resolved Hide resolved
@gab-arrobo
Copy link
Contributor

@thakurajayL, you need to sign-off you last commit (the DCO filed for it)

thakurajayL and others added 11 commits January 15, 2025 18:16
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
* add MongoDB functions to handle transactions

Signed-off-by: Patricia Reinoso <[email protected]>

* rename to supports transactions

Signed-off-by: Patricia Reinoso <[email protected]>

---------

Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
Signed-off-by: Ajay Lotan Thakur <[email protected]>
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with OnRamp using the replace directive in the amf pod/image)

@gab-arrobo gab-arrobo merged commit e70812b into main Jan 16, 2025
10 checks passed
@gab-arrobo gab-arrobo deleted the thakurajayL-patch branch January 16, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants